Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using deprecated InterceptorBindingRegistrar#registerAdditionalBindings #19656

Merged
merged 2 commits into from
Aug 26, 2021
Merged

Avoid using deprecated InterceptorBindingRegistrar#registerAdditionalBindings #19656

merged 2 commits into from
Aug 26, 2021

Conversation

gastaldi
Copy link
Contributor

@gastaldi gastaldi commented Aug 25, 2021 •
edited
Loading

This gets rid of some deprecated code usage

@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/security area/spring Issues relating to the Spring integration labels Aug 25, 2021
geoand
geoand reviewed Aug 25, 2021
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spring stuff looks good

@gastaldi gastaldi requested a review from sberyozkin August 25, 2021 16:42
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 25, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building c5c27c0

Status Name Step Test failures Logs Raw logs
✖ JVM Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
✖ JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
✖ JVM Tests - JDK 16 Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

⚠️ Errors occurred while downloading the Surefire reports. This report is incomplete.

Test Failures

⚙️ JVM Tests - JDK 11 Windows #

📦 independent-projects/arc/tests

✖ io.quarkus.arc.test.buildextension.interceptor.bindings.AdditionalInterceptorBindingsTest.testBindingWasRegisteredWithMatchingBindingField - More details - Source on GitHub

javax.enterprise.inject.spi.DefinitionException: Interceptor has no bindings: io.quarkus.arc.test.buildextension.interceptor.bindings.AdditionalInterceptorBindingsTest$MyInterceptorForNonBindingField
	at io.quarkus.arc.processor.Interceptors.createInterceptor(Interceptors.java:44)
	at io.quarkus.arc.processor.BeanDeployment.findInterceptors(BeanDeployment.java:1167)
	at io.quarkus.arc.processor.BeanDeployment.registerBeans(BeanDeployment.java:238)
	at io.quarkus.arc.processor.BeanProcessor.registerBeans(BeanProcessor.java:115)
	at io.quarkus.arc.processor.BeanProcessor.process(BeanProcessor.java:253)
	at io.quarkus.arc.test.ArcTestContainer.init(ArcTestContainer.java:409)
	at io.quarkus.arc.test.ArcTestContainer.beforeEach(ArcTestContainer.java:265)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeBeforeEachCallbacks$1(TestMethodTestDescriptor.java:159)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeBeforeMethodsOrCallbacks...

✖ io.quarkus.arc.test.buildextension.interceptor.bindings.AdditionalInterceptorBindingsTest.testBindingWasRegistered - More details - Source on GitHub

javax.enterprise.inject.spi.DefinitionException: Interceptor has no bindings: io.quarkus.arc.test.buildextension.interceptor.bindings.AdditionalInterceptorBindingsTest$MyInterceptorForNonBindingField
	at io.quarkus.arc.processor.Interceptors.createInterceptor(Interceptors.java:44)
	at io.quarkus.arc.processor.BeanDeployment.findInterceptors(BeanDeployment.java:1167)
	at io.quarkus.arc.processor.BeanDeployment.registerBeans(BeanDeployment.java:238)
	at io.quarkus.arc.processor.BeanProcessor.registerBeans(BeanProcessor.java:115)
	at io.quarkus.arc.processor.BeanProcessor.process(BeanProcessor.java:253)
	at io.quarkus.arc.test.ArcTestContainer.init(ArcTestContainer.java:409)
	at io.quarkus.arc.test.ArcTestContainer.beforeEach(ArcTestContainer.java:265)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeBeforeEachCallbacks$1(TestMethodTestDescriptor.java:159)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeBeforeMethodsOrCallbacks...

✖ io.quarkus.arc.test.buildextension.interceptor.bindings.AdditionalInterceptorBindingsTest.testBindingWasNotRegisteredWithMismatchingBindingField - More details - Source on GitHub

javax.enterprise.inject.spi.DefinitionException: Interceptor has no bindings: io.quarkus.arc.test.buildextension.interceptor.bindings.AdditionalInterceptorBindingsTest$MyInterceptorForNonBindingField
	at io.quarkus.arc.processor.Interceptors.createInterceptor(Interceptors.java:44)
	at io.quarkus.arc.processor.BeanDeployment.findInterceptors(BeanDeployment.java:1167)
	at io.quarkus.arc.processor.BeanDeployment.registerBeans(BeanDeployment.java:238)
	at io.quarkus.arc.processor.BeanProcessor.registerBeans(BeanProcessor.java:115)
	at io.quarkus.arc.processor.BeanProcessor.process(BeanProcessor.java:253)
	at io.quarkus.arc.test.ArcTestContainer.init(ArcTestContainer.java:409)
	at io.quarkus.arc.test.ArcTestContainer.beforeEach(ArcTestContainer.java:265)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeBeforeEachCallbacks$1(TestMethodTestDescriptor.java:159)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeBeforeMethodsOrCallbacks...

✖ io.quarkus.arc.test.buildextension.interceptor.bindings.AdditionalInterceptorBindingsTest.testBindingWasRegisteredWithNonBindingField - More details - Source on GitHub

javax.enterprise.inject.spi.DefinitionException: Interceptor has no bindings: io.quarkus.arc.test.buildextension.interceptor.bindings.AdditionalInterceptorBindingsTest$MyInterceptorForNonBindingField
	at io.quarkus.arc.processor.Interceptors.createInterceptor(Interceptors.java:44)
	at io.quarkus.arc.processor.BeanDeployment.findInterceptors(BeanDeployment.java:1167)
	at io.quarkus.arc.processor.BeanDeployment.registerBeans(BeanDeployment.java:238)
	at io.quarkus.arc.processor.BeanProcessor.registerBeans(BeanProcessor.java:115)
	at io.quarkus.arc.processor.BeanProcessor.process(BeanProcessor.java:253)
	at io.quarkus.arc.test.ArcTestContainer.init(ArcTestContainer.java:409)
	at io.quarkus.arc.test.ArcTestContainer.beforeEach(ArcTestContainer.java:265)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeBeforeEachCallbacks$1(TestMethodTestDescriptor.java:159)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeBeforeMethodsOrCallbacks...

⚙️ JVM Tests - JDK 16 #

📦 independent-projects/arc/tests

✖ io.quarkus.arc.test.buildextension.interceptor.bindings.AdditionalInterceptorBindingsTest.testBindingWasRegisteredWithMatchingBindingField - More details - Source on GitHub

javax.enterprise.inject.spi.DefinitionException: Interceptor has no bindings: io.quarkus.arc.test.buildextension.interceptor.bindings.AdditionalInterceptorBindingsTest$MyInterceptorForNonBindingField
	at io.quarkus.arc.processor.Interceptors.createInterceptor(Interceptors.java:44)
	at io.quarkus.arc.processor.BeanDeployment.findInterceptors(BeanDeployment.java:1167)
	at io.quarkus.arc.processor.BeanDeployment.registerBeans(BeanDeployment.java:238)
	at io.quarkus.arc.processor.BeanProcessor.registerBeans(BeanProcessor.java:115)
	at io.quarkus.arc.processor.BeanProcessor.process(BeanProcessor.java:253)
	at io.quarkus.arc.test.ArcTestContainer.init(ArcTestContainer.java:409)
	at io.quarkus.arc.test.ArcTestContainer.beforeEach(ArcTestContainer.java:265)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeBeforeEachCallbacks$1(TestMethodTestDescriptor.java:159)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeBeforeMethodsOrCallbacks...

✖ io.quarkus.arc.test.buildextension.interceptor.bindings.AdditionalInterceptorBindingsTest.testBindingWasRegistered - More details - Source on GitHub

javax.enterprise.inject.spi.DefinitionException: Interceptor has no bindings: io.quarkus.arc.test.buildextension.interceptor.bindings.AdditionalInterceptorBindingsTest$MyInterceptorForNonBindingField
	at io.quarkus.arc.processor.Interceptors.createInterceptor(Interceptors.java:44)
	at io.quarkus.arc.processor.BeanDeployment.findInterceptors(BeanDeployment.java:1167)
	at io.quarkus.arc.processor.BeanDeployment.registerBeans(BeanDeployment.java:238)
	at io.quarkus.arc.processor.BeanProcessor.registerBeans(BeanProcessor.java:115)
	at io.quarkus.arc.processor.BeanProcessor.process(BeanProcessor.java:253)
	at io.quarkus.arc.test.ArcTestContainer.init(ArcTestContainer.java:409)
	at io.quarkus.arc.test.ArcTestContainer.beforeEach(ArcTestContainer.java:265)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeBeforeEachCallbacks$1(TestMethodTestDescriptor.java:159)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeBeforeMethodsOrCallbacks...

✖ io.quarkus.arc.test.buildextension.interceptor.bindings.AdditionalInterceptorBindingsTest.testBindingWasNotRegisteredWithMismatchingBindingField - More details - Source on GitHub

javax.enterprise.inject.spi.DefinitionException: Interceptor has no bindings: io.quarkus.arc.test.buildextension.interceptor.bindings.AdditionalInterceptorBindingsTest$MyInterceptorForNonBindingField
	at io.quarkus.arc.processor.Interceptors.createInterceptor(Interceptors.java:44)
	at io.quarkus.arc.processor.BeanDeployment.findInterceptors(BeanDeployment.java:1167)
	at io.quarkus.arc.processor.BeanDeployment.registerBeans(BeanDeployment.java:238)
	at io.quarkus.arc.processor.BeanProcessor.registerBeans(BeanProcessor.java:115)
	at io.quarkus.arc.processor.BeanProcessor.process(BeanProcessor.java:253)
	at io.quarkus.arc.test.ArcTestContainer.init(ArcTestContainer.java:409)
	at io.quarkus.arc.test.ArcTestContainer.beforeEach(ArcTestContainer.java:265)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeBeforeEachCallbacks$1(TestMethodTestDescriptor.java:159)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeBeforeMethodsOrCallbacks...

✖ io.quarkus.arc.test.buildextension.interceptor.bindings.AdditionalInterceptorBindingsTest.testBindingWasRegisteredWithNonBindingField - More details - Source on GitHub

javax.enterprise.inject.spi.DefinitionException: Interceptor has no bindings: io.quarkus.arc.test.buildextension.interceptor.bindings.AdditionalInterceptorBindingsTest$MyInterceptorForNonBindingField
	at io.quarkus.arc.processor.Interceptors.createInterceptor(Interceptors.java:44)
	at io.quarkus.arc.processor.BeanDeployment.findInterceptors(BeanDeployment.java:1167)
	at io.quarkus.arc.processor.BeanDeployment.registerBeans(BeanDeployment.java:238)
	at io.quarkus.arc.processor.BeanProcessor.registerBeans(BeanProcessor.java:115)
	at io.quarkus.arc.processor.BeanProcessor.process(BeanProcessor.java:253)
	at io.quarkus.arc.test.ArcTestContainer.init(ArcTestContainer.java:409)
	at io.quarkus.arc.test.ArcTestContainer.beforeEach(ArcTestContainer.java:265)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeBeforeEachCallbacks$1(TestMethodTestDescriptor.java:159)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeBeforeMethodsOrCallbacks...

@michalszynkiewicz
Copy link
Member

@Ladicek the there are some failures in MP FT TCK, have you seen them before?

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 25, 2021

Failing Jobs - Building e6fecca

Status Name Step Test failures Logs Raw logs
✖ JVM Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 16
✖ MicroProfile TCKs Tests Verify Test failures Logs Raw logs

Full information is available in the Build summary check run.

⚠️ Errors occurred while downloading the Surefire reports. This report is incomplete.

Test Failures

⚙️ MicroProfile TCKs Tests #

📦 tcks/microprofile-fault-tolerance

✖ org.eclipse.microprofile.fault.tolerance.tck.TimeoutUninterruptableTest.testTimeoutAsyncBulkhead line 190 - More details - Source on GitHub

java.lang.AssertionError: Unexpected exception thrown from Future
	at org.testng.Assert.fail(Assert.java:85)
	at org.eclipse.microprofile.fault.tolerance.tck.util.Exceptions.expect(Exceptions.java:98)
	at org.eclipse.microprofile.fault.tolerance.tck.TimeoutUninterruptableTest.testTimeoutAsyncBulkhead(TimeoutUninterruptableTest.java:190)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at io.quarkus.arquillian.QuarkusProtocol$QuarkusMethodExecutor$1.invoke(QuarkusProtocol.java:87)
	at org.jboss.arquillian.container.test.impl.execution.LocalTestExecuter.execute(LocalTestExecuter.java:57)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base...

@Ladicek
Copy link
Contributor

Ladicek commented Aug 26, 2021

@michalszynkiewicz yea that test is flaky, see smallrye/smallrye-fault-tolerance#233

@michalszynkiewicz
Copy link
Member

The other failing tests are for Kafka, also not related.

@michalszynkiewicz michalszynkiewicz merged commit 132a087 into quarkusio:main Aug 26, 2021
@quarkus-bot quarkus-bot bot added this to the 2.3 - main milestone Aug 26, 2021
@gastaldi gastaldi deleted the bindings branch August 26, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand left review comments

@michalszynkiewicz michalszynkiewicz michalszynkiewicz approved these changes

@mkouba mkouba Awaiting requested review from mkouba

@sberyozkin sberyozkin Awaiting requested review from sberyozkin

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection) area/security area/spring Issues relating to the Spring integration
Projects
None yet
Milestone
2.3.0.CR1
Development

Successfully merging this pull request may close these issues.
4 participants
@gastaldi @michalszynkiewicz @Ladicek @geoand